Refactor code structure for improved readability and maintainability

backend/tests/routes/games.spec.ts

@@ -252,6 +252,149 @@ describe('Games API', () => {
       expect(res.statusCode).toBe(404);
     });
   });
+
+  describe('POST /api/games/from-metadata', () => {
+    it('debería crear un juego a partir de metadatos', async () => {
+      const payload = {
+        metadata: {
+          source: 'igdb',
+          externalIds: { igdb: 1234 },
+          name: 'Super Mario Bros.',
+          slug: 'super-mario-bros',
+          releaseDate: '1985-09-13T00:00:00.000Z',
+          genres: ['Platform'],
+          coverUrl: 'https://example.com/cover.jpg',
+        },
+      };
+
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload,
+      });
+
+      expect(res.statusCode).toBe(201);
+      const body = res.json();
+      expect(body).toHaveProperty('id');
+      expect(body.title).toBe('Super Mario Bros.');
+      expect(body.source).toBe('igdb');
+      expect(body.sourceId).toBe('1234');
+    });
+
+    it('debería crear un juego con overrides', async () => {
+      const platform = await prisma.platform.create({
+        data: { name: 'Nintendo Entertainment System', slug: 'nes' },
+      });
+
+      const payload = {
+        metadata: {
+          source: 'igdb',
+          externalIds: { igdb: 1234 },
+          name: 'Super Mario Bros.',
+          slug: 'super-mario-bros',
+          releaseDate: '1985-09-13T00:00:00.000Z',
+          genres: ['Platform'],
+          coverUrl: 'https://example.com/cover.jpg',
+        },
+        overrides: {
+          platformId: platform.id,
+          description: 'Descripción personalizada',
+          priceCents: 10000,
+          currency: 'USD',
+          store: 'eBay',
+          date: '2025-01-15',
+          condition: 'CIB',
+        },
+      };
+
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload,
+      });
+
+      expect(res.statusCode).toBe(201);
+      const body = res.json();
+      expect(body.title).toBe('Super Mario Bros.');
+      expect(body.description).toBe('Descripción personalizada');
+      expect(body.gamePlatforms).toHaveLength(1);
+      expect(body.gamePlatforms[0].platformId).toBe(platform.id);
+      expect(body.purchases).toHaveLength(1);
+      expect(body.purchases[0].priceCents).toBe(10000);
+    });
+
+    it('debería devolver 400 si falta el campo metadata', async () => {
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload: {},
+      });
+
+      expect(res.statusCode).toBe(400);
+    });
+
+    it('debería devolver 400 si metadata.name está vacío', async () => {
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload: {
+          metadata: {
+            source: 'igdb',
+            externalIds: { igdb: 1234 },
+            name: '',
+            slug: 'super-mario-bros',
+          },
+        },
+      });
+
+      expect(res.statusCode).toBe(400);
+    });
+
+    it('debería usar el externalId principal como sourceId', async () => {
+      const payload = {
+        metadata: {
+          source: 'rawg',
+          externalIds: { rawg: 5678, igdb: 1234 },
+          name: 'Zelda',
+          slug: 'zelda',
+        },
+      };
+
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload,
+      });
+
+      expect(res.statusCode).toBe(201);
+      const body = res.json();
+      expect(body.source).toBe('rawg');
+      expect(body.sourceId).toBe('5678');
+    });
+
+    it('debería manejar metadata sin externalIds', async () => {
+      const payload = {
+        metadata: {
+          source: 'manual',
+          externalIds: {},
+          name: 'Custom Game',
+          slug: 'custom-game',
+        },
+      };
+
+      const res = await app.inject({
+        method: 'POST',
+        url: '/api/games/from-metadata',
+        payload,
+      });
+
+      expect(res.statusCode).toBe(201);
+      const body = res.json();
+      expect(body.title).toBe('Custom Game');
+      expect(body.source).toBe('manual');
+      expect(body.sourceId).toBeNull();
+    });
+  });
 });
 
 /**

backend/tests/routes/metadata.spec.ts

@@ -17,20 +17,33 @@ describe('Metadata API', () => {
   });
 
   describe('GET /api/metadata/search', () => {
-    it('debería devolver resultados cuando se busca un juego existente', async () => {
+    it('debería devolver múltiples resultados cuando se busca un juego existente', async () => {
       const mockResults = [
         {
-          source: 'igdb',
+          source: 'igdb' as const,
           externalIds: { igdb: 1 },
+          name: 'The Legend of Zelda',
           title: 'The Legend of Zelda',
           slug: 'the-legend-of-zelda',
           releaseDate: '1986-02-21',
           genres: ['Adventure'],
           coverUrl: 'https://example.com/cover.jpg',
+          platforms: undefined,
+        },
+        {
+          source: 'rawg' as const,
+          externalIds: { rawg: 2 },
+          name: 'The Legend of Zelda: A Link to the Past',
+          title: 'The Legend of Zelda: A Link to the Past',
+          slug: 'the-legend-of-zelda-a-link-to-the-past',
+          releaseDate: '1991-11-21',
+          genres: ['Adventure'],
+          coverUrl: 'https://example.com/cover2.jpg',
+          platforms: undefined,
         },
       ];
 
-      vi.spyOn(metadataService, 'enrichGame').mockResolvedValue(mockResults[0]);
+      vi.spyOn(metadataService, 'searchGames').mockResolvedValue(mockResults);
 
       const res = await app.inject({
         method: 'GET',
@@ -41,11 +54,11 @@ describe('Metadata API', () => {
       const body = res.json();
       expect(Array.isArray(body)).toBe(true);
       expect(body.length).toBeGreaterThan(0);
-      expect(body[0].title).toContain('Zelda');
+      expect(body[0].name).toContain('Zelda');
     });
 
     it('debería devolver lista vacía cuando no hay resultados', async () => {
-      vi.spyOn(metadataService, 'enrichGame').mockResolvedValue(null);
+      vi.spyOn(metadataService, 'searchGames').mockResolvedValue([]);
 
       const res = await app.inject({
         method: 'GET',
@@ -77,8 +90,8 @@ describe('Metadata API', () => {
       expect(res.statusCode).toBe(400);
     });
 
-    it('debería pasar el parámetro platform a enrichGame si se proporciona', async () => {
-      const enrichSpy = vi.spyOn(metadataService, 'enrichGame').mockResolvedValue(null);
+    it('debería pasar el parámetro platform a searchGames si se proporciona', async () => {
+      const searchSpy = vi.spyOn(metadataService, 'searchGames').mockResolvedValue([]);
 
       const res = await app.inject({
         method: 'GET',
@@ -86,9 +99,42 @@ describe('Metadata API', () => {
       });
 
       expect(res.statusCode).toBe(200);
-      expect(enrichSpy).toHaveBeenCalledWith({
+      expect(searchSpy).toHaveBeenCalledWith({
         title: 'mario',
         platform: 'Nintendo 64',
+        year: undefined,
+      });
+    });
+
+    it('debería pasar el parámetro year a searchGames si se proporciona', async () => {
+      const searchSpy = vi.spyOn(metadataService, 'searchGames').mockResolvedValue([]);
+
+      const res = await app.inject({
+        method: 'GET',
+        url: '/api/metadata/search?q=mario&year=1990',
+      });
+
+      expect(res.statusCode).toBe(200);
+      expect(searchSpy).toHaveBeenCalledWith({
+        title: 'mario',
+        platform: undefined,
+        year: 1990,
+      });
+    });
+
+    it('debería pasar todos los parámetros a searchGames', async () => {
+      const searchSpy = vi.spyOn(metadataService, 'searchGames').mockResolvedValue([]);
+
+      const res = await app.inject({
+        method: 'GET',
+        url: '/api/metadata/search?q=mario&platform=NES&year=1985',
+      });
+
+      expect(res.statusCode).toBe(200);
+      expect(searchSpy).toHaveBeenCalledWith({
+        title: 'mario',
+        platform: 'NES',
+        year: 1985,
       });
     });
   });